Skip to content

Onboard the GitHub Action based Issue-Labeler #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jeffhandley
Copy link
Member

These workflows replace the issue-labeler implementation that runs as a GitHub app, allowing training and prediction for the repository's labels without the need for an external service. We will decommission that service once all repositories migrate to the new implementation.

References:

Once this is merged, we will need to run the 'Labeler: Training' workflow to train new prediction models, then 'Labeler: Promotion' workflow to promote the models into active use, and then I will disable the integration of the legacy issue-labeler app for this repo.

The legacy issue-labeler was configured to apply the untriaged label to new issues in this repository. The new Issue Labeler does not have that functionality; it exclusively handles predicting labels (such as area- labels). This PR retains the untriaged label automation and improves it by using the 1ES policy-service for automatically applying the label to new issues, unless there is already a milestone or assignee applied. That policy will also automatically remove the untriaged label when a milestone or assignee is applied, which seems to match how issues in this repository are managed. But let me know if you'd like that logic updated.

@jeffhandley jeffhandley self-assigned this May 3, 2025
@jeffhandley jeffhandley requested a review from a team as a code owner May 3, 2025 00:14
@ghost ghost added the untriaged label May 3, 2025
@jeffhandley jeffhandley force-pushed the jeffhandley/issue-labeler-v2.0.0 branch from d1cc64a to 822d884 Compare May 3, 2025 01:34
@jeffhandley
Copy link
Member Author

I see from this PR itself that the legacy issue-labeler is also applying untriaged to new PRs. Let me know if you'd like to retain that behavior; if so, I can update the untriaged policy here to add that logic as well.

@NikolaMilosavljevic
Copy link
Member

I see from this PR itself that the legacy issue-labeler is also applying untriaged to new PRs. Let me know if you'd like to retain that behavior; if so, I can update the untriaged policy here to add that logic as well.

I don't think untriaged label for PRs is necessary. I see that PRs in other repos that use GH action-based issue labeler do not get this label by default. That seems like a better model.

@jeffhandley
Copy link
Member Author

Cool; then this is ready to go, @NikolaMilosavljevic.

Once this is merged, we will need to run the 'Labeler: Training' workflow to train new prediction models, then 'Labeler: Promotion' workflow to promote the models into active use, and then I will disable the integration of the legacy issue-labeler app for this repo. Let me know if you have questions or issues running those workflows.

@NikolaMilosavljevic
Copy link
Member

Cool; then this is ready to go, @NikolaMilosavljevic.

Once this is merged, we will need to run the 'Labeler: Training' workflow to train new prediction models, then 'Labeler: Promotion' workflow to promote the models into active use, and then I will disable the integration of the legacy issue-labeler app for this repo. Let me know if you have questions or issues running those workflows.

Great! Do we need any more fixes made in other repo PRs, i.e. dotnet/runtime#115256?

@jeffhandley
Copy link
Member Author

Sure; I can pull the comments and the markdown doc over into here too. Will have that here very shortly...

@jeffhandley
Copy link
Member Author

Thanks, @NikolaMilosavljevic. I noticed the 'Actions' tab is not visible on this repo, so it's possible actions need to be enabled as well.

The Required GitHub Actions settings part of the onboarding page has the instructions. I'm happy to walk through that with you if you'd like.

I won't hit the merge button since I won't have permissions to configure that or run the 'Training', 'Promotion', or 'Cache Retention' workflows. After those are run once manually, everything will be automatic thereafter until you ever reach the point of needing to train the models again.

@NikolaMilosavljevic
Copy link
Member

Thanks @jeffhandley - I've enabled actions and updated other settings to match those in the guide.

@NikolaMilosavljevic NikolaMilosavljevic merged commit f2d6daa into dotnet:main May 7, 2025
10 checks passed
@jeffhandley jeffhandley deleted the jeffhandley/issue-labeler-v2.0.0 branch May 7, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants