Skip to content

Pluralizes multi-arguments option audience to audiences #1186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 16, 2025
Merged

Pluralizes multi-arguments option audience to audiences #1186

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3dca12a
Pluralizes multi-arguments option audience to audiences
Bartizan May 15, 2025
d7c358f
Merge branch 'main' into pluralize-multi-args-options
waldekmastykarz May 16, 2025
dcc6a1c
Adjust variable name jwtAudiencesOption with the plural name
Bartizan May 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions dev-proxy/ProxyHost.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,11 +416,11 @@ private static Command CreateJwtCreateCommand()
var jwtNameOption = new Option<string>("--name", "The name of the user to create the token for.");
jwtNameOption.AddAlias("-n");

var jwtAudienceOption = new Option<IEnumerable<string>>("--audience", "The audiences to create the token for. Specify once for each audience")
var jwtAudiencesOption = new Option<IEnumerable<string>>("--audiences", "The audiences to create the token for. Specify once for each audience")
{
AllowMultipleArgumentsPerToken = true
};
jwtAudienceOption.AddAlias("-a");
jwtAudiencesOption.AddAlias("-a");

var jwtIssuerOption = new Option<string>("--issuer", "The issuer of the token.");
jwtIssuerOption.AddAlias("-i");
Expand Down Expand Up @@ -494,7 +494,7 @@ private static Command CreateJwtCreateCommand()
JwtCommandHandler.GetToken,
new JwtBinder(
jwtNameOption,
jwtAudienceOption,
jwtAudiencesOption,
jwtIssuerOption,
jwtRolesOption,
jwtScopesOption,
Expand All @@ -507,7 +507,7 @@ private static Command CreateJwtCreateCommand()
var sortedOptions = new Option[]
{
jwtNameOption,
jwtAudienceOption,
jwtAudiencesOption,
jwtIssuerOption,
jwtRolesOption,
jwtScopesOption,
Expand Down