Fixes text centering causing offsets by some glyphs #31412
+3
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @@dotMorten! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes text centering issues in FontImageSource rendering on Windows that was causing glyph offsets. The fix updates the positioning calculation to properly center glyphs within the canvas.
- Replaces incorrect DrawBounds-based positioning with proper canvas centering calculation
- Uses LayoutBounds and DefaultFontSize for more accurate text positioning
src/Core/src/ImageSources/FontImageSourceService/FontImageSourceService.Windows.cs
Outdated
Show resolved
Hide resolved
src/Core/src/ImageSources/FontImageSourceService/FontImageSourceService.Windows.cs
Outdated
Show resolved
Hide resolved
…ceService.Windows.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
@clandrew @shawnhar This is the best I could come up with to fix the text centering issue, but you two might be the best ones to confirm the use of CanvasTextLayout and calculating centering. Would appreciate your input on this. I didn't really find anything else in the layout that gave the values needed to correctly center the symbol. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
The font alignment calculation was wrong, often causing the symbols to be offset when rendering using
FontImageSource.Issues Fixed
Fixes #30004
Below is an example of the adjustment. First column using
<Label />to render the Glyph, second is how MAUI currently renders it, and 3rd column with the fix applied. I applied a background to the two images, to make it clear that the generated image hasn't changed, only the alignment.