-
Notifications
You must be signed in to change notification settings - Fork 5k
Source Build Validation legs are failing #114842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
FYI we'll be removing these legs soon: dotnet/source-build#5021 |
cc @omajid |
It would be best to add their coverage to VMR before removing them from runtime. i.e. dotnet/source-build#4918 then dotnet/source-build#5021. I think the ultimate test for RID agnostic-ness is NonexistentRID, if we can make it green we can be confident that there is no unintended inference from RID in the code. 🙂 |
👍 In our internal CI we have a test that build the vmr with some random target rid (that doesn't match /etc/os-release). Then we take those assets to another system (which rid matches neither the initial system nor the target rid) and use them for a non-portable build. |
@tmds would you mind filing an issue at https://github.com/dotnet/source-build to track adding a validation job that verifies that the VMR can be built with a random banana target rid? |
With these changes,
<AppHostRuntimeIdentifier Condition="'$(OutputRID)' != '$(NETCoreSdkRuntimeIdentifier)' and '$(BaseOS)' != '' ">$(BaseOS)</AppHostRuntimeIdentifier> @ViktorHofer @jkoritzinsky should I make a PR to add this? When #114285 is merged, it is no longer needed. |
I thought about this. Previously .NET rids were determined at runtime from /etc/os-release while for recent versions the rid gets fixed at build time ( If we mix up the Target RID with the build SDK RID in some places, cross-build CI will pick that up. As a result, I think we have good coverage already with the vmr CI that is in place. I assume this issue isn't picked up by that CI because it is in a tests project that the vmr doesn't restore. |
Looks like it is regressed by
|
@am11 non-portable build was working after the changes made for #114285 (comment). I assume some later change regressed it. |
I'm testing with
Testing in the CI reveals different situation #115272. Trying to figure out the built arg differences.. |
The command from that comment fails against |
Ah thanks. For some reason, my previous click scrolled to your next comment. Let me take a look. |
Source-Build (CentOS9)
is failing with:https://dev.azure.com/dnceng-public/public/_build/results?buildId=1021233&view=logs&jobId=46d4bc78-82b7-5486-55ce-7714ebdf0ac0&j=527da66b-556b-54bb-107f-cdc8a55a2854&t=255f8d3e-16e8-5d6d-908e-7cc01450d912
and
Source-Build (NonexistentRID)
- the purpose of this one is to validate that we don't take a dependency on non-portable RID's value and distro maintainer is free to choose the identifier prefix:https://dev.azure.com/dnceng-public/public/_build/results?buildId=1021233&view=logs&jobId=46d4bc78-82b7-5486-55ce-7714ebdf0ac0&j=46d4bc78-82b7-5486-55ce-7714ebdf0ac0&t=5940e102-b135-58b6-71a4-2593b90abf9d
cc @jkoritzinsky, @tmds, last time they appeared passing was in December, then three months logs are missing and since then, all red: https://dev.azure.com/dnceng-public/public/_build?definitionId=129&_a=summary&branchFilter=331%2C331%2C331

it's the second circle:
The text was updated successfully, but these errors were encountered: