-
Notifications
You must be signed in to change notification settings - Fork 5k
Improve crossbuild inference #115247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve crossbuild inference #115247
Conversation
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries |
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
@ViktorHofer, could you please take a look? We decided to not added |
Can we please hold this one until dotnet/dotnet#176 goes in? I expect that to happen this week. That moves the remaining DotNetBuild.props arguments into the VMR. Asking as we don't have a property like |
Sure, this is actually similar to #115272 (using |
@am11 I'm closing this PR as runtime's DotNetBuild.props file got removed with dotnet/dotnet@2774010 (the change will flow into runtime tomorrow). That arg is now here: https://github.com/dotnet/dotnet/blob/025e4e597746eafc5a736195b66aeb321455d64c/repo-projects/runtime.proj#L27 If this still needs an update, would you mind submitting a PR to dotnet/dotnet (we don't yet advertise that possibility, so please keep that scoped to just that one PR and change for now)? Thanks in advance |
This should cover freebsd-on-linux etc. type of rootfs cases.
Thanks to @tmds for suggesting it dotnet/sdk#48591 (comment).