Skip to content

Improve crossbuild inference #115247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Improve crossbuild inference #115247

wants to merge 5 commits into from

Conversation

am11
Copy link
Member

@am11 am11 commented May 2, 2025

This should cover freebsd-on-linux etc. type of rootfs cases.

Thanks to @tmds for suggesting it dotnet/sdk#48591 (comment).

@am11 am11 requested a review from jkoritzinsky May 2, 2025 16:36
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label May 2, 2025
@am11 am11 added source-build Issues relating to dotnet/source-build area-Infrastructure and removed area-Infrastructure-libraries labels May 2, 2025
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Copy link
Contributor

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

@am11
Copy link
Member Author

am11 commented May 5, 2025

@ViktorHofer, could you please take a look? We decided to not added --cross as it was almost auto-inferred except for the ROOTFS case where OS are different (e.g. freebsd on linux).

@ViktorHofer
Copy link
Member

Can we please hold this one until dotnet/dotnet#176 goes in? I expect that to happen this week. That moves the remaining DotNetBuild.props arguments into the VMR.

Asking as we don't have a property like PortableOS there and TargetOS gets set differently in the VMR. I.e. it is linux-bionix or linux-musl which it isn't the case for runtime from what I understand.

@am11
Copy link
Member Author

am11 commented May 5, 2025

Sure, this is actually similar to #115272 (using PortableOS to infer the cross-ness). It shouldn't interfere with TargetOS or anything else.

@ViktorHofer
Copy link
Member

@am11 I'm closing this PR as runtime's DotNetBuild.props file got removed with dotnet/dotnet@2774010 (the change will flow into runtime tomorrow).

That arg is now here: https://github.com/dotnet/dotnet/blob/025e4e597746eafc5a736195b66aeb321455d64c/repo-projects/runtime.proj#L27

If this still needs an update, would you mind submitting a PR to dotnet/dotnet (we don't yet advertise that possibility, so please keep that scoped to just that one PR and change for now)? Thanks in advance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Infrastructure community-contribution Indicates that the PR has been added by a community member source-build Issues relating to dotnet/source-build
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants