Lookup R2R unwind info via R2R data structures #120758
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lookup image runtime functions via R2R data structures instead of via PE data structures. This will make it easier to add support for non-PE R2R composite envlopes.
Contributor
|
Tagging subscribers to this area: @steveisok, @dotnet/dotnet-diag |
Contributor
There was a problem hiding this comment.
Pull Request Overview
Switch runtime function lookup for ReadyToRun (R2R) methods from PE image directory parsing to direct use of R2R-maintained runtime function arrays, enabling future non-PE composite envelope support.
- Replaced PE-based exception directory traversal with direct table pointer and count.
- Updated JitTokenToReadyToRunInfo to return DAC-friendly PTR_ReadyToRunInfo.
- Adjusted unwind info enumeration to use R2R data structure members directly.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/coreclr/vm/codeman.h | Updated JitTokenToReadyToRunInfo return type to PTR_ReadyToRunInfo. |
| src/coreclr/vm/codeman.cpp | Refactored runtime function entry enumeration to use R2R tables; updated call sites accordingly. |
This was referenced Oct 16, 2025
Open
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lookup image runtime functions via R2R data structures instead of via PE data structures.
This will make it easier to add support for non-PE R2R composite envelopes.