Keep Publish* properties across Restore so that we can gather all required implicit packages #49501
+63
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #49493
Before, when the implicit Restore was triggered for the packages we would unconditionally set the Publish* properties to
false
. This caused Restore to not add the implicit packages to the trimming tools, so later when theILLink
target was called we'd invoke the dummy one from the SDK, not the actual one from the ILLink targets package.Added a test that checks the trimmed package contents and ensures that a dll whose functionality we never use is not in the package. We could also do a size-based check here - the trimmed packages are currently ~9MB vs the full packages which are ~25MB.