Potential sign-extending cast when a zero-extending cast was intended

[GrabYourPitchforks]

Testing out some new CodeQL rules locally. One of them flagged a line in WPF that appears suspicious.

wpf/src/Microsoft.DotNet.Wpf/src/UIAutomation/UIAutomationClientSideProviders/MS/Internal/AutomationProxies/CommonXSendMessage.cs

Line 1535 in 1e89865

return (ulong)(status) >> 30 == 3;

This expression always returns false because an explicit cast from int -> ulong is actually treated by the compiler as int -> long -> ulong (note the intermediate implicit sign-extending cast).

[ThomasGoulet73]

It's effectively dead code, NT_ERROR is only called in one place and only when running on Windows 2000 (Which hasn't been supported in a while):

wpf/src/Microsoft.DotNet.Wpf/src/UIAutomation/UIAutomationClientSideProviders/MS/Internal/AutomationProxies/CommonXSendMessage.cs

Lines 1507 to 1520 in 9103b82

	// Windows 2000 (major version 5)
	else if (Environment.OSVersion.Version.Major == 5)
	{
	// NtQueryInformationProcess is available for use in Windows 2000 and Windows XP.
	// It may be altered or unavailable in subsequent versions. Applications should use the alternate functions
	ulong infoWOW64 = 0;
	int status = UnsafeNativeMethods.NtQueryInformationProcess(hProcess, UnsafeNativeMethods.ProcessWow64Information, ref infoWOW64, sizeof(ulong), null);
	if (NT_ERROR(status))
	{
	// Query failed. Assume not running under WOW64.
	return false;
	}
	return infoWOW64 != 0;
	}

I'm assigning this issue to myself and I'll open a PR where I just remove the dead code.