Fix: Nix flake fails to run cargo +nightly fmt
#204
Merged
+20
−58
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
If you take the following steps:
nix./.envrcfile with contents "use flake".direnv allow(the rust toolchain is then downloaded).Running
pre-commit run --all-filesorcargo +nightly fmt(given in.pre-commit-config.yaml) fails with:And I can see that the nightly toolchain is needed, because without it,
cargo fmtgives:This PR
This update will not affect anybody not using nix.
This PR changes the nix flake as follows:
rustupinstead of installing a specific version ofcargo.shell.nix:flake.nix, but seems to incorrectly use the outdated cached shell when you updateshell.nix.venvautomatically when youcdto this repo. (Thevenvstill needs to be created manually: seeREADME.md).PR Tests
I have tested that the following commands run successfully:
make build-extension-debugpytestcargo testmake testpre-commit run --all-filesmake pcc