fix(web): add support for custom headers for web #2459
Conversation
There was a problem hiding this comment.
@michabrem thanks for the PR! left you a couple of questions.
web/TrackPlayer/Player.ts
Outdated
| private addHeaders(track: Track) { | ||
| if (track.headers) { | ||
| const networkingEngine = this.player?.getNetworkingEngine(); | ||
| networkingEngine?.clearAllRequestFilters(); |
There was a problem hiding this comment.
@michabrem , if track 1 has headers, and track 2 does not, wouldn't this result in the headers for track 1 being sent on the .load call of track 2?
There was a problem hiding this comment.
True, I have adjusted that to clear the request filters regardless of header or not, that should do the trick imo.
web/TrackPlayer/Player.ts
Outdated
| networkingEngine?.clearAllRequestFilters(); | ||
| networkingEngine?.registerRequestFilter((type, request) => { | ||
| if (type === 0 || type === 1) { | ||
| Object.entries(track.headers || {}).forEach(([key, value]) => { |
There was a problem hiding this comment.
@michabrem it might be more concise to express this like:
request.headers = {
...track.headers,
...request.headers,
}I realize this is technically an additional "copy", but it's easier to read IMHO. Thoughts?
Ensure that custom headers from the track entity are properly applied to HTTP requests in the web implementation. This fix dynamically registers request filters in the Shaka Player's NetworkingEngine.
michabrem
force-pushed
the
fix/web-add-headers-support
branch
from
c1c3771 to
d07a681
Compare
thanks, i've finally had the time to come back to this. Tested it locally with my web app and it works with the changes. |
2 participants
Ensure that custom headers from the track entity are properly applied to HTTP requests in the web implementation. This fix dynamically registers request filters in the Shaka Player's NetworkingEngine.