Regression in --export output which affects typical udev rule usage #63
Description
I've run into a regression in sg3_utils, unfortunately. It was introduced in 0f1230a --
sg_readcap+sg_luns: add --inhex= and json
Also add --sinq_inraw= to sg_readcap and sg_luns.
Add hex reference files for sg_luns and sg_readcap
in inhex directory for testing plus a
inq_standard.raw in the same directory.
git-svn-id: https://svn.bingwo.ca/repos/sg3_utils/trunk@1001 6180dd3e-e324-4e3e-922d-17de1ae2f315
This change included a whole lot of refactoring (in part) to support json formatted output. If I'm understanding correctly, handling of inquiry response length was changed over to use an existing function local len variable. However, len was already being used in the --export output handling, so ends up getting clobbered when --export is used, resulting in missing information.
After this change sg_inq --export <dev> no longer prints SCSI_MODEL, SCSI_MODEL_ENC, and SCSI_REVISION. This results in these udev properties being absent, so any rules matching on a model string will no longer function.
This affects the upcoming Debian Trixie (13) release, and PVE 9 (because it is based on Debian 13)... Likely other distributions are affected, since this is a 2 year old change.
I guess sg3_utils is in transition now (as mentioned in #62). I'm not sure what this means for a release, but I guess Debian and/or PVE probably needs to patch this by hand.