-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
chore: support sqlalchemy 2.x and flask-sqlalchemy 3 (breaking) #2241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Related: #2240 |
This reverts commit 9b19585.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2241 +/- ##
==========================================
+ Coverage 73.81% 74.21% +0.39%
==========================================
Files 72 76 +4
Lines 8754 9206 +452
==========================================
+ Hits 6462 6832 +370
- Misses 2292 2374 +82
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Just noting here that this ends up limiting us to using older versions of Pandas because |
def init_app(self, app: Flask) -> None: | ||
session_options = app.config.get("SQLALCHEMY_SESSION_OPTIONS", {}) | ||
if session_options: | ||
self.session = self._make_scoped_session(session_options) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @dpgaspar - we are testing the alpha version of FAB 5 for Airlow and we think this one gives us a hard time running our tests.
Basically in our tests we are creating a number of FabAppBuilders (and we override some parts of it) - but we have an issue that when we access a session in pytest (and we run init_app
multiple times in the same interpreter - in pytest - every time with a different App, the session that gets created here stays connected - we have > 90 connections to PostgresDB while running tests and we have very hard time on tracking where and how they should be closed.
Does it ring a bell?
Description
ADDITIONAL INFORMATION