Open
Conversation
codecov
ghost
requested a review
from 
dealmeidavf
reviewed
Feb 6, 2020
Member
dealmeidavf
left a comment
dealmeidavf
left a comment
There was a problem hiding this comment.
Let's discuss this. This certainly uncovers the issue with Pandas dataframes but a better fix is inside the Phase interface and not removing its usage. Changing Phase internally will preserve the interface and usage for all other modules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes performance issues with the
droplet_swirlexample by replacing containers with built-in types and implementing one Vortex per Droplet.