Skip to content

Support query params on DELETE requests, closes #29 #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 31, 2024

Conversation

dpup
Copy link
Owner

@dpup dpup commented May 30, 2024

Please review the following commits I made in branch dan/delete-with-params:

0047159 (2024-05-30 16:54:13 -0700)
Support query params on DELETE requests, closes #29

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

@dpup dpup merged commit ef9f14b into main May 31, 2024
2 checks passed
@dpup dpup deleted the dan/delete-with-params branch May 31, 2024 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow query params on delete requests
1 participant