feat: handle json_name in protos#38
Open
hishamank wants to merge 1 commit into
Open
Conversation
dpup
reviewed
Oct 28, 2025
Owner
dpup
left a comment
dpup
left a comment
There was a problem hiding this comment.
Only 6 months late in reviewing this. Not sure why I didn't see it.
I think we need to document and test the interaction between use_proto_names and use_json_name.
|
|
||
| ### `use_json_name` (Default: False) | ||
|
|
||
| Uses the `json_name` field option instead of the default field name when serializing messages to JSON. |
Owner
There was a problem hiding this comment.
Suggested change
| Uses the `json_name` field option instead of the default field name when serializing messages to JSON. | |
| When true, uses the `json_name` field option from proto definitions for JSON serialization, if available. This allows you to specify custom field names in JSON that differ from the default behavior. Example: | |
| ```protobuf | |
| message User { | |
| string user_id = 1 [json_name = "id"]; // Will use "id" in JSON | |
| } |
| // Message has been marked as deprecated | ||
| IsDeprecated bool | ||
| // JsonName is the json_name option from the proto field, if set. | ||
| JsonName string |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.