fix: huge TTL in RESTORE cmd is rounded to kMaxExpireDeadlineMs (#4589)

Author: BorysTheDev

src/server/generic_family.cc

@@ -106,17 +106,17 @@ ::io::Result<size_t> InMemSource::ReadSome(const iovec* v, uint32_t len) {
 
 class RestoreArgs {
  private:
-  static constexpr time_t NO_EXPIRATION = 0;
+  static constexpr int64_t NO_EXPIRATION = 0;
 
-  time_t expiration_ = NO_EXPIRATION;
+  int64_t expiration_ = NO_EXPIRATION;
   bool abs_time_ = false;
   bool replace_ = false;  // if true, over-ride existing key
   bool sticky_ = false;
 
  public:
   RestoreArgs() = default;
 
-  RestoreArgs(time_t expiration, bool abs_time, bool replace)
+  RestoreArgs(int64_t expiration, bool abs_time, bool replace)
       : expiration_(expiration), abs_time_(abs_time), replace_(replace) {
   }
 
@@ -236,7 +236,7 @@ pair<DbSlice::ItAndUpdater, bool> RdbRestoreValue::Add(string_view key, string_v
   if (HasExpiration()) {
     int64_t ttl = abs_time_ ? expiration_ - now_msec : expiration_;
     if (ttl > kMaxExpireDeadlineMs)
-      return false;
+      ttl = kMaxExpireDeadlineMs;
 
     expiration_ = ttl < 0 ? -1 : ttl + now_msec;
   }
@@ -326,7 +326,7 @@ class Renamer {
   struct SerializedValue {
     std::string value;
     std::optional<RdbVersion> version;
-    time_t expire_ts;
+    int64_t expire_ts;
     bool sticky;
   };
 

src/server/string_family_test.cc

@@ -528,6 +528,13 @@ TEST_F(StringFamilyTest, IncrByFloat) {
   EXPECT_EQ(resp, "3.566");
 }
 
+TEST_F(StringFamilyTest, RestoreHighTTL) {
+  Run({"SET", "X", "1"});
+  auto buffer = Run({"DUMP", "X"}).GetBuf();
+  Run({"DEL", "X"});
+  EXPECT_EQ(Run({"RESTORE", "X", "5430186761345", ToSV(buffer)}), "OK");
+}
+
 TEST_F(StringFamilyTest, SetNx) {
   // Make sure that we "screen out" invalid parameters for this command
   // this is important as it uses similar path as the "normal" set