Skip to content

Commit 373a30d

Browse files
authored
fix: add peer to task failed because InnerBucketMaxLength is small (#765)
Signed-off-by: santong <weipeng.swp@alibaba-inc.com>
1 parent 51b36b5 commit 373a30d

File tree

2 files changed

+15
-5
lines changed

2 files changed

+15
-5
lines changed

pkg/structure/sortedlist/sorted_list.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@ import (
2121
"sync"
2222
)
2323

24-
const BucketMaxLength = 10000
25-
const InnerBucketMaxLength = 100
24+
const BucketMaxLength = 100000
25+
const InnerBucketMaxLength = 10000
2626

2727
type Item interface {
2828
GetSortKeys() (key1 int, key2 int)

scheduler/supervisor/task.go

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -261,16 +261,26 @@ func (task *Task) UpdateSuccess(pieceCount int32, contentLength int64) {
261261
}
262262

263263
func (task *Task) AddPeer(peer *Peer) {
264-
task.peers.UpdateOrAdd(peer)
264+
err := task.peers.UpdateOrAdd(peer)
265+
if err != nil {
266+
task.logger.Errorf("add peer %s failed: %v", peer.ID, err)
267+
}
265268
task.logger.Debugf("peer %s has been added, current total peer count is %d", peer.ID, task.peers.Size())
266269
}
267270

268271
func (task *Task) UpdatePeer(peer *Peer) {
269-
task.peers.Update(peer)
272+
err := task.peers.Update(peer)
273+
if err != nil {
274+
task.logger.Errorf("update peer %s failed: %v", peer.ID, err)
275+
}
276+
task.logger.Debugf("peer %s has been updated, current total peer count is %d", peer.ID, task.peers.Size())
270277
}
271278

272279
func (task *Task) DeletePeer(peer *Peer) {
273-
task.peers.Delete(peer)
280+
err := task.peers.Delete(peer)
281+
if err != nil {
282+
task.logger.Errorf("delete peer %s failed: %v", peer.ID, err)
283+
}
274284
task.logger.Debugf("peer %s has been deleted, current total peer count is %d", peer.ID, task.peers.Size())
275285
}
276286

0 commit comments

Comments
 (0)