refactor(client): streamline error handling in peerTaskConductor and pieceManager

- Consolidate error messages for content length mismatches in peerTaskConductor
- Simplify error creation in pieceManager for source response validation
- Enhance logging consistency and clarity across error handling

Signed-off-by: jinronga <1460595002@qq.com>

Author: jinronga

client/daemon/peer/peertask_conductor.go

@@ -990,10 +990,9 @@ func (pt *peerTaskConductor) updateMetadata(piecePacket *commonv1.PiecePacket) {
 		pt.Debugf("update content length: %d, dst peer %s", piecePacket.ContentLength, piecePacket.DstPid)
 	} else if piecePacket.ContentLength > -1 && piecePacket.ContentLength != pt.GetContentLength() {
 		// corrupt data check
-		reason := fmt.Sprintf("corrupt data - content length did not match, current: %d, from piece packet: %d",
+		pt.Errorf("corrupt data - content length did not match, current: %d, from piece packet: %d",
 			pt.GetContentLength(), piecePacket.ContentLength)
-		pt.Errorf(reason)
-		pt.cancel(commonv1.Code_ClientError, reason)
+		pt.cancel(commonv1.Code_ClientError, "corrupt data - content length did not match")
 		return
 	}
 
@@ -1191,10 +1190,9 @@ func (pt *peerTaskConductor) isCompleted() bool {
 
 	// corrupt data check and avoid hang for mismatch completed length
 	if pt.readyPieces.Settled() == pt.totalPiece.Load() {
-		msg := fmt.Sprintf("corrupt data - ready piece count %d seems finished, but completed length %d is not match with content length: %d",
+		pt.Errorf("corrupt data - ready piece count %d seems finished, but completed length %d is not match with content length: %d",
 			pt.totalPiece.Load(), pt.completedLength.Load(), pt.GetContentLength())
-		pt.Errorf(msg)
-		pt.cancel(commonv1.Code_ClientError, msg)
+		pt.cancel(commonv1.Code_ClientError, "corrupt data - ready piece count seems finished but completed length does not match")
 		return true
 	}
 

client/daemon/peer/piece_manager.go

@@ -387,8 +387,7 @@ singleDownload:
 	if err != nil {
 		log.Errorf("back source status code %d/%s", response.StatusCode, response.Status)
 		// convert error details to status
-		st := status.Newf(codes.Aborted,
-			fmt.Sprintf("source response %d/%s is not valid", response.StatusCode, response.Status))
+		st := status.Newf(codes.Aborted, "source response %d/%s is not valid", response.StatusCode, response.Status)
 		hdr := map[string]string{}
 		for k, v := range response.Header {
 			if len(v) > 0 {