Skip to content

Commit 8a85e7d

Browse files
committed
feat: add error logging for preheat failures and fix peer selection logic
Signed-off-by: Gaius <gaius.qi@gmail.com>
1 parent f9d576d commit 8a85e7d

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

scheduler/job/job.go

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -183,6 +183,7 @@ func (j *job) preheat(ctx context.Context, data string) (string, error) {
183183
log.Info("[preheat]: preheat single seed peer")
184184
resp, err := j.preheatSingleSeedPeer(ctx, req, log)
185185
if err != nil {
186+
log.Errorf("[preheat]: preheat single seed peer failed: %s", err.Error())
186187
return "", err
187188
}
188189

@@ -192,6 +193,7 @@ func (j *job) preheat(ctx context.Context, data string) (string, error) {
192193
log.Info("[preheat]: preheat all seed peers")
193194
resp, err := j.preheatAllSeedPeers(ctx, req, log)
194195
if err != nil {
196+
log.Errorf("[preheat]: preheat all seed peers failed: %s", err.Error())
195197
return "", err
196198
}
197199

@@ -201,6 +203,7 @@ func (j *job) preheat(ctx context.Context, data string) (string, error) {
201203
log.Info("[preheat]: preheat all peers")
202204
resp, err := j.preheatAllPeers(ctx, req, log)
203205
if err != nil {
206+
log.Errorf("[preheat]: preheat all peers failed: %s", err.Error())
204207
return "", err
205208
}
206209

@@ -210,6 +213,7 @@ func (j *job) preheat(ctx context.Context, data string) (string, error) {
210213
log.Warnf("[preheat]: scope is invalid %s, preheat single peer", req.Scope)
211214
resp, err := j.preheatSingleSeedPeer(ctx, req, log)
212215
if err != nil {
216+
log.Errorf("[preheat]: preheat single seed peer failed: %s", err.Error())
213217
return "", err
214218
}
215219

@@ -538,7 +542,7 @@ func (j *job) selectSeedPeers(ips []string, count *uint32, percentage *uint8, lo
538542
for _, seedPeer := range seedPeers {
539543
if slices.Contains(ips, seedPeer.Ip) {
540544
selectedSeedPeers = append(selectedSeedPeers, seedPeer)
541-
break
545+
continue
542546
}
543547
}
544548

@@ -739,7 +743,7 @@ func (j *job) selectPeers(ips []string, count *uint32, percentage *uint8, log *l
739743
for _, peer := range peers {
740744
if slices.Contains(ips, peer.IP) {
741745
selectedPeers = append(selectedPeers, peer)
742-
break
746+
continue
743747
}
744748
}
745749

0 commit comments

Comments
 (0)