feat(client): removing hostname resolution fallback when the IP address check fails (#3936)

feat(client): remove check health for scheduler

Signed-off-by: Gaius <gaius.qi@gmail.com>

Author: gaius-qi

client/config/dynconfig_manager.go

@@ -119,28 +119,15 @@ func (d *dynconfigManager) GetResolveSchedulerAddrs() ([]resolver.Address, error
 			dialOptions = append(dialOptions, grpc.WithTransportCredentials(insecure.NewCredentials()))
 		}
 
-		var addr string
-		if ip, ok := ip.FormatIP(scheduler.GetIp()); ok {
-			// Check health with ip address.
-			target := fmt.Sprintf("%s:%d", ip, scheduler.GetPort())
-			if err := healthclient.Check(context.Background(), target, dialOptions...); err != nil {
-				logger.Warnf("scheduler ip address %s is unreachable: %s", target, err.Error())
-
-				// Check health with host address.
-				target = fmt.Sprintf("%s:%d", scheduler.GetHostname(), scheduler.GetPort())
-				if err := healthclient.Check(context.Background(), target, dialOptions...); err != nil {
-					logger.Warnf("scheduler host address %s is unreachable: %s", target, err.Error())
-				} else {
-					addr = target
-				}
-			} else {
-				addr = target
-			}
+		ip, ok := ip.FormatIP(scheduler.GetIp())
+		if !ok {
+			logger.Warnf("invalid IP format for scheduler: %s", scheduler.GetIp())
+			continue
 		}
 
-		if addr == "" {
-			logger.Warnf("scheduler %s %s %d has not reachable addresses",
-				scheduler.GetIp(), scheduler.GetHostname(), scheduler.GetPort())
+		addr := fmt.Sprintf("%s:%d", ip, scheduler.GetPort())
+		if err := healthclient.Check(context.Background(), addr, dialOptions...); err != nil {
+			logger.Warnf("scheduler %s is unreachable: %s", addr, err.Error())
 			continue
 		}
 

client/config/dynconfig_manager_test.go

@@ -217,9 +217,8 @@ func TestDynconfigManager_GetResolveSchedulerAddrs(t *testing.T) {
 			},
 			expect: func(t *testing.T, dynconfig Dynconfig, data *DynconfigData) {
 				assert := assert.New(t)
-				result, err := dynconfig.GetResolveSchedulerAddrs()
-				assert.NoError(err)
-				assert.EqualValues(result, []resolver.Address{{ServerName: "localhost", Addr: "localhost:3000"}})
+				_, err := dynconfig.GetResolveSchedulerAddrs()
+				assert.Error(err)
 			},
 		},
 		{