Skip to content

Conversation

gaius-qi
Copy link
Member

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Signed-off-by: Gaius <gaius.qi@gmail.com>
Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi added the enhancement New feature or request label Aug 14, 2024
@gaius-qi gaius-qi added this to the v2.2.0 milestone Aug 14, 2024
@gaius-qi gaius-qi self-assigned this Aug 14, 2024
@gaius-qi gaius-qi requested a review from a team as a code owner August 14, 2024 12:56
…e/api

Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi force-pushed the feature/job branch 2 times, most recently from 93c6579 to e4f8229 Compare August 15, 2024 11:01
yxxhero
yxxhero previously approved these changes Aug 15, 2024
Signed-off-by: Gaius <gaius.qi@gmail.com>
Copy link

codecov bot commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 23.52941% with 39 lines in your changes missing coverage. Please review.

Project coverage is 52.49%. Comparing base (5547307) to head (1051baf).
Report is 6 commits behind head on main.

Files Patch % Lines
manager/job/task.go 0.00% 18 Missing ⚠️
manager/job/job.go 0.00% 8 Missing ⚠️
scheduler/resource/task.go 0.00% 7 Missing ⚠️
manager/job/preheat.go 0.00% 3 Missing ⚠️
client/daemon/peer/peertask_reuse.go 50.00% 0 Missing and 2 partials ⚠️
client/daemon/transport/transport.go 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3434      +/-   ##
==========================================
- Coverage   52.56%   52.49%   -0.07%     
==========================================
  Files         194      194              
  Lines       20578    20589      +11     
==========================================
- Hits        10816    10808       -8     
- Misses       8952     8967      +15     
- Partials      810      814       +4     
Flag Coverage Δ
unittests 52.49% <23.52%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
manager/config/config.go 96.15% <ø> (-0.06%) ⬇️
manager/handlers/job.go 63.85% <100.00%> (ø)
pkg/idgen/task_id.go 82.35% <100.00%> (ø)
client/daemon/transport/transport.go 38.25% <66.66%> (+0.32%) ⬆️
client/daemon/peer/peertask_reuse.go 63.25% <50.00%> (-0.70%) ⬇️
manager/job/preheat.go 51.70% <0.00%> (-0.49%) ⬇️
scheduler/resource/task.go 77.43% <0.00%> (-1.05%) ⬇️
manager/job/job.go 0.00% <0.00%> (ø)
manager/job/task.go 0.00% <0.00%> (ø)

... and 4 files with indirect coverage changes

… feature/job

Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi requested a review from a team as a code owner August 15, 2024 13:10
@gaius-qi gaius-qi requested a review from jim3ma August 15, 2024 13:10
@gaius-qi gaius-qi force-pushed the feature/job branch 7 times, most recently from 298cdff to 3a3815d Compare August 16, 2024 06:46
Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi merged commit 517aed7 into main Aug 16, 2024
29 checks passed
@gaius-qi gaius-qi deleted the feature/job branch August 16, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants