Skip to content

Conversation

gaius-qi
Copy link
Member

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi added the enhancement New feature or request label Aug 16, 2024
@gaius-qi gaius-qi added this to the v2.2.0 milestone Aug 16, 2024
@gaius-qi gaius-qi self-assigned this Aug 16, 2024
@gaius-qi gaius-qi requested a review from a team as a code owner August 16, 2024 10:37
Copy link

codecov bot commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.64%. Comparing base (d68e707) to head (bd1e6e0).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3438   +/-   ##
=======================================
  Coverage   52.64%   52.64%           
=======================================
  Files         194      194           
  Lines       20587    20587           
=======================================
  Hits        10837    10837           
  Misses       8942     8942           
  Partials      808      808           
Flag Coverage Δ
unittests 52.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gaius-qi gaius-qi merged commit eaaeec4 into main Aug 19, 2024
29 checks passed
@gaius-qi gaius-qi deleted the feature/console branch August 19, 2024 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants