Skip to content

Conversation

IRONICBo
Copy link
Contributor

@IRONICBo IRONICBo commented Sep 9, 2024

Description

Update rpc to clear the cache of the task id on the peer, and a query api to query the status of the asynchronous task and aggregate it into the existing asynchronous task creation logic.

Meanwhile, this PR add a e2e test for get task and delete task job.

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Local Test Doc

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Signed-off-by: Asklv <boironic@gmail.com>
…onse to JSONMap.

Signed-off-by: Asklv <boironic@gmail.com>
Signed-off-by: Asklv <boironic@gmail.com>
Signed-off-by: Asklv <boironic@gmail.com>
Signed-off-by: Asklv <boironic@gmail.com>
Signed-off-by: Asklv <boironic@gmail.com>
@IRONICBo IRONICBo requested a review from a team as a code owner September 9, 2024 11:22
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 137 lines in your changes missing coverage. Please review.

Project coverage is 51.67%. Comparing base (d68e707) to head (c243745).
Report is 28 commits behind head on main.

Files with missing lines Patch % Lines
manager/job/task.go 0.00% 54 Missing ⚠️
scheduler/resource/peer.go 0.00% 44 Missing ⚠️
scheduler/resource/seed_peer_client_mock.go 0.00% 25 Missing ⚠️
pkg/container/set/safe_set.go 0.00% 14 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3490      +/-   ##
==========================================
- Coverage   52.64%   51.67%   -0.97%     
==========================================
  Files         194      189       -5     
  Lines       20587    20389     -198     
==========================================
- Hits        10837    10536     -301     
- Misses       8942     9048     +106     
+ Partials      808      805       -3     
Flag Coverage Δ
unittests 51.67% <0.00%> (-0.97%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pkg/container/set/safe_set.go 75.43% <0.00%> (-24.57%) ⬇️
scheduler/resource/seed_peer_client_mock.go 16.56% <0.00%> (-2.88%) ⬇️
scheduler/resource/peer.go 59.36% <0.00%> (-12.62%) ⬇️
manager/job/task.go 0.00% <0.00%> (ø)

... and 33 files with indirect coverage changes

@IRONICBo IRONICBo closed this Sep 9, 2024
@IRONICBo IRONICBo reopened this Sep 10, 2024
@IRONICBo IRONICBo closed this Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant