Skip to content

Conversation

BruceAko
Copy link
Member

@BruceAko BruceAko commented Mar 18, 2025

Description

  • Changed key formatting in LoadAll methods of peer and task managers to use a prefix with wildcard for scanning.
  • Renamed LoadCorrentReplicaCount to LoadCurrentReplicaCount for consistency.
  • Added test cases for handling invalid peer and task keys in respective test files.

Related Issue

#3892

Screenshot

09235e9001e2f4503ebbc1cfcea8e3d8

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

…rmat

Signed-off-by: BruceAko <chongzhi@hust.edu.cn>
@BruceAko BruceAko requested a review from a team as a code owner March 18, 2025 05:09
Copy link

codecov bot commented Mar 18, 2025

Codecov Report

Attention: Patch coverage is 63.04348% with 17 lines in your changes missing coverage. Please review.

Project coverage is 35.04%. Comparing base (324eb86) to head (4de9468).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
scheduler/resource/persistentcache/task_manager.go 77.27% 3 Missing and 2 partials ⚠️
scheduler/service/service_v2.go 0.00% 5 Missing ⚠️
...uler/resource/persistentcache/task_manager_mock.go 0.00% 4 Missing ⚠️
scheduler/resource/persistentcache/peer_manager.go 80.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3902   +/-   ##
=======================================
  Coverage   35.03%   35.04%           
=======================================
  Files         337      337           
  Lines       39343    39373   +30     
=======================================
+ Hits        13785    13799   +14     
- Misses      24658    24669   +11     
- Partials      900      905    +5     
Flag Coverage Δ
unittests 35.04% <63.04%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
scheduler/resource/persistentcache/peer_manager.go 40.66% <80.00%> (+1.18%) ⬆️
...uler/resource/persistentcache/task_manager_mock.go 25.86% <0.00%> (ø)
scheduler/resource/persistentcache/task_manager.go 43.91% <77.27%> (+2.97%) ⬆️
scheduler/service/service_v2.go 46.29% <0.00%> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@BruceAko BruceAko requested a review from gaius-qi March 18, 2025 07:04
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Signed-off-by: BruceAko <chongzhi@hust.edu.cn>
@BruceAko BruceAko merged commit 901a0d1 into dragonflyoss:main Mar 18, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants