Skip to content

Conversation

SouthWest7
Copy link
Contributor

@SouthWest7 SouthWest7 commented Apr 10, 2025

Description

This update adds load_to_cache arg when using Open API to preheat and enhances the preheat test case for 100MiB file in cache by adding metrics validation.

Changes

New Struct Member

Code Perfection

Test Cases

  • test/e2e/v2/manager/preheat.go: Frist preheat file in cache of a seedclient,then other seedclient download file from it, validating using traffic and storage type.
    Uploading image.png…

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Signed-off-by: southwest <1403572259@qq.com>
Signed-off-by: southwest miao <1403572259@qq.com>
Signed-off-by: southwest miao <1403572259@qq.com>
Signed-off-by: southwest miao <1403572259@qq.com>
Signed-off-by: southwest miao <1403572259@qq.com>
Signed-off-by: southwest miao <1403572259@qq.com>
Signed-off-by: southwest miao <1403572259@qq.com>
@SouthWest7 SouthWest7 requested a review from a team as a code owner April 10, 2025 12:30
Copy link

codecov bot commented Apr 10, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 34.51%. Comparing base (4265552) to head (a7e7ef9).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
scheduler/job/job.go 0.00% 3 Missing ⚠️
manager/job/preheat.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3941      +/-   ##
==========================================
- Coverage   34.55%   34.51%   -0.04%     
==========================================
  Files         339      339              
  Lines       39937    39944       +7     
==========================================
- Hits        13800    13788      -12     
- Misses      25234    25249      +15     
- Partials      903      907       +4     
Flag Coverage Δ
unittests 34.51% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
manager/job/preheat.go 45.92% <0.00%> (-0.18%) ⬇️
scheduler/job/job.go 0.00% <0.00%> (ø)

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: southwest miao <1403572259@qq.com>
@gaius-qi gaius-qi requested a review from Copilot April 11, 2025 07:08
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Signed-off-by: southwest miao <1403572259@qq.com>
Signed-off-by: southwest miao <1403572259@qq.com>
Signed-off-by: southwest miao <1403572259@qq.com>
Signed-off-by: southwest miao <1403572259@qq.com>
Signed-off-by: southwest miao <1403572259@qq.com>
Signed-off-by: southwest miao <1403572259@qq.com>
gaius-qi
gaius-qi previously approved these changes Apr 14, 2025
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: southwest miao <1403572259@qq.com>
Signed-off-by: southwest miao <1403572259@qq.com>
Signed-off-by: southwest miao <1403572259@qq.com>
@SouthWest7 SouthWest7 requested a review from mfarooq-tech April 14, 2025 13:20
Signed-off-by: southwest miao <1403572259@qq.com>
Signed-off-by: southwest miao <1403572259@qq.com>
Signed-off-by: southwest miao <1403572259@qq.com>
Signed-off-by: southwest miao <1403572259@qq.com>
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit 9422ac9 into dragonflyoss:main Apr 15, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants