Skip to content

Conversation

gaius-qi
Copy link
Member

Description

This pull request includes several changes to improve error logging, optimize code, and adjust default settings. The most important changes are summarized below:

Enhancements to logging:

  • manager/searcher/searcher.go: Updated the logging statement to use logger.Warnf instead of logger.Info when loading the searcher plugin fails, providing more context about the error.

Code optimization:

  • manager/searcher/searcher.go: Simplified the calculateMultiElementAffinityScore function by replacing a conditional block with a single min function and modifying the loop to use range.

Adjustments to default settings:

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi added the enhancement New feature or request label Apr 10, 2025
@gaius-qi gaius-qi added this to the v2.3.0 milestone Apr 10, 2025
@gaius-qi gaius-qi self-assigned this Apr 10, 2025
@gaius-qi gaius-qi requested a review from a team as a code owner April 10, 2025 15:32
@gaius-qi gaius-qi merged commit 8eed7f6 into main Apr 10, 2025
25 checks passed
@gaius-qi gaius-qi deleted the feature/log branch April 10, 2025 15:38
Copy link

codecov bot commented Apr 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.51%. Comparing base (e8166e4) to head (324fe27).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3942      +/-   ##
==========================================
- Coverage   34.53%   34.51%   -0.02%     
==========================================
  Files         339      339              
  Lines       39943    39937       -6     
==========================================
- Hits        13796    13786      -10     
- Misses      25242    25244       +2     
- Partials      905      907       +2     
Flag Coverage Δ
unittests 34.51% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
manager/searcher/searcher.go 73.94% <100.00%> (+2.04%) ⬆️
pkg/rpc/scheduler/server/server.go 100.00% <ø> (ø)

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants