Skip to content

Conversation

gaius-qi
Copy link
Member

Description

This pull request includes a minor change to the manager/service/persistent_cache_task.go file. The change corrects the logging statement to use the correct variable for the peer ID.

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi added the enhancement New feature or request label Apr 15, 2025
@gaius-qi gaius-qi added this to the v2.3.0 milestone Apr 15, 2025
@gaius-qi gaius-qi self-assigned this Apr 15, 2025
@gaius-qi gaius-qi requested a review from a team as a code owner April 15, 2025 06:46
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@fcgxz2003 fcgxz2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Apr 15, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 34.52%. Comparing base (5065e9d) to head (987689b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
manager/service/persistent_cache_task.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3954   +/-   ##
=======================================
  Coverage   34.52%   34.52%           
=======================================
  Files         339      339           
  Lines       39944    39944           
=======================================
  Hits        13789    13789           
- Misses      25248    25249    +1     
+ Partials      907      906    -1     
Flag Coverage Δ
unittests 34.52% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
manager/service/persistent_cache_task.go 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gaius-qi gaius-qi merged commit 3da4f63 into main Apr 15, 2025
27 checks passed
@gaius-qi gaius-qi deleted the feature/log branch April 15, 2025 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants