Skip to content

Conversation

chlins
Copy link
Member

@chlins chlins commented Apr 16, 2025

This pull request introduces a new audit logging feature, updates dependencies, and makes configuration changes. The most important changes include the addition of audit logging functionality, updates to the API documentation, and dependency updates.

Audit Logging Feature:

API Documentation:

Dependency Updates:

  • CHANGELOG.md: Updated to reflect the bump in dependencies for various packages.

Configuration Changes:

These changes collectively enhance the functionality, maintainability, and observability of the system.

Description

Related Issue

#3937
#3811

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@chlins chlins added the enhancement New feature or request label Apr 16, 2025
@chlins chlins added this to the v2.3.0 milestone Apr 16, 2025
@chlins chlins requested a review from a team as a code owner April 16, 2025 03:23
@chlins chlins requested review from garenwen, yyzai384 and akashhr April 16, 2025 03:23
@chlins chlins force-pushed the feat/audit branch 2 times, most recently from 82df752 to 38bb16e Compare April 16, 2025 03:30
Copy link

codecov bot commented Apr 16, 2025

Codecov Report

❌ Patch coverage is 13.60544% with 127 lines in your changes missing coverage. Please review.
✅ Project coverage is 34.45%. Comparing base (8d2d672) to head (c846cfd).
⚠️ Report is 236 commits behind head on main.

Files with missing lines Patch % Lines
manager/service/audit.go 0.00% 67 Missing ⚠️
manager/middlewares/audit.go 0.00% 39 Missing ⚠️
manager/service/mocks/service_mock.go 55.55% 8 Missing ⚠️
manager/router/router.go 0.00% 7 Missing ⚠️
manager/handlers/audit.go 71.42% 3 Missing and 1 partial ⚠️
manager/database/database.go 0.00% 1 Missing ⚠️
manager/middlewares/personal_access_token.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3958      +/-   ##
==========================================
- Coverage   34.54%   34.45%   -0.10%     
==========================================
  Files         339      342       +3     
  Lines       39944    40091     +147     
==========================================
+ Hits        13800    13812      +12     
- Misses      25241    25373     +132     
- Partials      903      906       +3     
Flag Coverage Δ
unittests 34.45% <13.60%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
api/manager/docs.go 0.00% <ø> (ø)
manager/service/service.go 0.00% <ø> (ø)
manager/database/database.go 0.00% <0.00%> (ø)
manager/middlewares/personal_access_token.go 0.00% <0.00%> (ø)
manager/handlers/audit.go 71.42% <71.42%> (ø)
manager/router/router.go 0.00% <0.00%> (ø)
manager/service/mocks/service_mock.go 91.42% <55.55%> (-0.83%) ⬇️
manager/middlewares/audit.go 0.00% <0.00%> (ø)
manager/service/audit.go 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@chlins chlins force-pushed the feat/audit branch 2 times, most recently from 562171e to 173a378 Compare April 16, 2025 04:24
@chlins chlins enabled auto-merge (squash) April 16, 2025 04:24
Signed-off-by: chlins <chlins.zhang@gmail.com>
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@Liam-Zhao Liam-Zhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chlins chlins merged commit bf5a3cb into dragonflyoss:main Apr 16, 2025
27 of 31 checks passed
@chlins chlins mentioned this pull request Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants