Skip to content

Conversation

chlins
Copy link
Member

@chlins chlins commented Apr 16, 2025

This pull request primarily updates the Go version from 1.23.0 to 1.23.8 across various Dockerfiles and the go.mod file. This change ensures that the project uses the latest patch version of Go, which includes important bug fixes and security updates.

Key changes include:

  • Dockerfiles:

    • Updated the Go version to 1.23.8 in build/images/base/Dockerfile.
    • Updated the Go version to 1.23.8 in build/images/dfdaemon/Dockerfile.
    • Updated the Go version to 1.23.8 in build/images/manager/Dockerfile.
    • Updated the Go version to 1.23.8 in build/images/scheduler/Dockerfile.
    • Updated the Go version to 1.23.8 in build/plugin-builder/Dockerfile.
    • Updated the Go version to 1.23.8 in test/tools/no-content-length/Dockerfile.
  • Configuration files:

    • Updated the Go version to 1.23.8 in go.mod.
    • Updated the build image to use Go 1.23.8 in hack/build.sh.

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Signed-off-by: chlins <chlins.zhang@gmail.com>
@chlins chlins requested a review from a team as a code owner April 16, 2025 08:23
@chlins chlins added the dependencies Pull requests that update a dependency file label Apr 16, 2025
@chlins chlins added this to the v2.3.0 milestone Apr 16, 2025
Copy link

@Liam-Zhao Liam-Zhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chlins chlins enabled auto-merge (squash) April 16, 2025 08:24
Copy link

codecov bot commented Apr 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.52%. Comparing base (8d2d672) to head (fa64268).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3960      +/-   ##
==========================================
- Coverage   34.54%   34.52%   -0.03%     
==========================================
  Files         339      339              
  Lines       39944    39944              
==========================================
- Hits        13800    13789      -11     
- Misses      25241    25249       +8     
- Partials      903      906       +3     
Flag Coverage Δ
unittests 34.52% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chlins chlins merged commit b267a5d into dragonflyoss:main Apr 16, 2025
28 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants