Skip to content

Conversation

yxxhero
Copy link
Member

@yxxhero yxxhero commented Apr 16, 2025

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@yxxhero yxxhero requested a review from a team as a code owner April 16, 2025 13:38
@yxxhero yxxhero requested review from imeoer, yyzai384 and akashhr April 16, 2025 13:38
Copy link

codecov bot commented Apr 16, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 34.44%. Comparing base (bf5a3cb) to head (7c015bf).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cmd/dfget/cmd/root.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3961      +/-   ##
==========================================
- Coverage   34.44%   34.44%   -0.01%     
==========================================
  Files         342      342              
  Lines       40091    40092       +1     
==========================================
  Hits        13809    13809              
- Misses      25376    25377       +1     
  Partials      906      906              
Flag Coverage Δ
unittests 34.44% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
cmd/dfget/cmd/root.go 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

@Liam-Zhao Liam-Zhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yxxhero yxxhero merged commit 916eff7 into main Apr 16, 2025
28 of 29 checks passed
@yxxhero yxxhero deleted the build(client-rs)--update-subproject-commit-and-add-comment-in-dfget branch April 16, 2025 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants