Skip to content

Conversation

yxxhero
Copy link
Member

@yxxhero yxxhero commented Apr 16, 2025

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Signed-off-by: yxxhero <aiopsclub@163.com>
@yxxhero yxxhero requested a review from a team as a code owner April 16, 2025 13:41
Copy link

codecov bot commented Apr 16, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 34.45%. Comparing base (916eff7) to head (0115402).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cmd/dfget/cmd/root.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3962      +/-   ##
==========================================
- Coverage   34.48%   34.45%   -0.03%     
==========================================
  Files         342      342              
  Lines       40092    40091       -1     
==========================================
- Hits        13824    13812      -12     
- Misses      25363    25373      +10     
- Partials      905      906       +1     
Flag Coverage Δ
unittests 34.45% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
cmd/dfget/cmd/root.go 0.00% <0.00%> (ø)

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

@Liam-Zhao Liam-Zhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yxxhero yxxhero enabled auto-merge (squash) April 16, 2025 14:29
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yxxhero yxxhero disabled auto-merge April 17, 2025 02:38
@gaius-qi gaius-qi enabled auto-merge (squash) April 17, 2025 02:39
@gaius-qi gaius-qi merged commit ea52a84 into main Apr 17, 2025
27 checks passed
@gaius-qi gaius-qi deleted the refactor(root.go)--simplify-error-handling-in-checkAndSpawnDaemon branch April 17, 2025 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants