fix(peer/peertask_conductor): correct error handling in storeTinyPeer… #3980
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3980 +/- ##
==========================================
- Coverage 34.42% 34.42% -0.01%
==========================================
Files 342 342
Lines 40079 40080 +1
==========================================
- Hits 13799 13798 -1
- Misses 25372 25374 +2
Partials 908 908
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
…Task Signed-off-by: yxxhero <aiopsclub@163.com>
chlins
force-pushed
the
fix(peer/peertask_conductor)--correct-error-handling-in-storeTinyPeerTask
branch
from
e025909 to
d5ad78e
Compare
chlins
deleted the
fix(peer/peertask_conductor)--correct-error-handling-in-storeTinyPeerTask
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes a minor update to the error handling in the
storeTinyPeerTaskmethod of thepeerTaskConductorstruct. The change improves error reporting by ensuring that the same error message is logged and passed to thecancelmethod.Error handling improvement:
client/daemon/peer/peertask_conductor.go: Replaced the inline error message inpt.cancelwith a formatted string stored in theressonvariable, ensuring consistency between the logged error and the cancellation reason.