Skip to content

Conversation

yxxhero
Copy link
Member

@yxxhero yxxhero commented Apr 23, 2025

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Signed-off-by: yxxhero <aiopsclub@163.com>
@yxxhero yxxhero requested a review from a team as a code owner April 23, 2025 05:49
Copy link

codecov bot commented Apr 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.40%. Comparing base (8c23c8b) to head (6102893).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3985   +/-   ##
=======================================
  Coverage   34.40%   34.40%           
=======================================
  Files         341      341           
  Lines       40072    40071    -1     
=======================================
  Hits        13786    13786           
+ Misses      25380    25379    -1     
  Partials      906      906           
Flag Coverage Δ
unittests 34.40% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
scheduler/resource/standard/task_manager.go 87.80% <ø> (+2.09%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

@Liam-Zhao Liam-Zhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chlins chlins enabled auto-merge (squash) April 23, 2025 09:03
@chlins chlins merged commit 5bd4ae5 into main Apr 23, 2025
27 checks passed
@chlins chlins deleted the refactor(task_manager)--Remove-unnecessary-error-log-in-RunGC branch April 23, 2025 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants