feat: resolve statsview hanging issue by improving port handling and shutdown logic #3986
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request refactors the monitoring initialization logic to improve clarity and maintainability. The key changes include replacing the use of
freeport
with a simplified configuration for statsview, renaming variables for better readability, and updating the shutdown handling mechanism.Refactoring of monitoring initialization:
freeport
dependency and replaced the dynamic port assignment with a direct configuration usingnet.IPv4zero
for statsview. This simplifies the initialization process for monitoring. (cmd/dependency/dependency.go
, [1] [2]fc
channel toshutdowns
for better semantic clarity, and updated the logging messages to reflect this change. (cmd/dependency/dependency.go
, cmd/dependency/dependency.goL96-R124)cmd/dependency/dependency.go
, cmd/dependency/dependency.goL96-R124)Updates to shutdown handling:
InitMonitor
function to return ashutdown
function instead of a channel, improving the readability and usage of the function. (cmd/dependency/dependency.go
, cmd/dependency/dependency.goL96-R124)InitMonitor
inrunManager
andrunScheduler
functions with the updatedshutdown
mechanism to align with the refactored implementation. (cmd/manager/cmd/root.go
, [1];cmd/scheduler/cmd/root.go
, [2]Related Issue
Motivation and Context
Screenshots (if appropriate)
Types of changes
Checklist