Skip to content

Conversation

gaius-qi
Copy link
Member

Description

This pull request updates the .github/workflows/release.yml file to enhance the release workflow by modifying how the tag_name output is handled and ensuring consistency in the workflow configuration.

Key changes to the release workflow:

  • Addition of tag_name output in goreleaser job:

    • Added a new output tag_name to the goreleaser job to capture the tag name generated during the build process. ([.github/workflows/release.ymlR19](https://github.com/dragonflyoss/dragonfly/pull/3988/files#diff-87db21a973eed4fef5f32b267aa60fcee5cbdf03c67fafdc2a9b553bb0b15f34R19))
  • Update to upload-tag-name in slsa-github-generator:

    • Updated the upload-tag-name input to use the tag_name output from the goreleaser job instead of the release job, ensuring the correct tag name is passed for the release process. ([.github/workflows/release.ymlR73-L73](https://github.com/dragonflyoss/dragonfly/pull/3988/files#diff-87db21a973eed4fef5f32b267aa60fcee5cbdf03c67fafdc2a9b553bb0b15f34R73-L73))

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

…ectly pass tag_name output to SLSA generator

Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi added the enhancement New feature or request label Apr 23, 2025
@gaius-qi gaius-qi added this to the v2.3.0 milestone Apr 23, 2025
@gaius-qi gaius-qi requested a review from Copilot April 23, 2025 09:20
@gaius-qi gaius-qi self-assigned this Apr 23, 2025
@gaius-qi gaius-qi requested a review from a team as a code owner April 23, 2025 09:20
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the release workflow configuration to correctly pass the tag name output from the goreleaser job to the SLSA generator, ensuring consistency during the release process.

  • Added a new output "tag_name" in the goreleaser job to capture the generated tag.
  • Updated the slsa-github-generator job to use the "tag_name" output from goreleaser instead of the previous reference.

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

@Liam-Zhao Liam-Zhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chlins chlins enabled auto-merge (squash) April 23, 2025 09:22
Copy link

codecov bot commented Apr 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.40%. Comparing base (5bd4ae5) to head (eb4537a).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3988      +/-   ##
==========================================
- Coverage   34.40%   34.40%   -0.01%     
==========================================
  Files         341      341              
  Lines       40070    40070              
==========================================
- Hits        13788    13785       -3     
- Misses      25375    25377       +2     
- Partials      907      908       +1     
Flag Coverage Δ
unittests 34.40% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@chlins chlins merged commit 2d331fc into main Apr 23, 2025
27 checks passed
@chlins chlins deleted the feature/tag-name branch April 23, 2025 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants