Skip to content

Conversation

yxxhero
Copy link
Member

@yxxhero yxxhero commented May 9, 2025

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Signed-off-by: yxxhero <aiopsclub@163.com>
@yxxhero yxxhero requested a review from a team as a code owner May 9, 2025 12:25
@yxxhero yxxhero added the enhancement New feature or request label May 9, 2025
@yxxhero yxxhero requested review from jim3ma, hyy0322 and mfarooq-tech May 9, 2025 12:25
Copy link

codecov bot commented May 9, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 34.34%. Comparing base (80d109e) to head (7fb09fc).

Files with missing lines Patch % Lines
manager/handlers/audit.go 0.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4051      +/-   ##
==========================================
- Coverage   34.40%   34.34%   -0.06%     
==========================================
  Files         344      344              
  Lines       40299    40300       +1     
==========================================
- Hits        13864    13842      -22     
- Misses      25522    25542      +20     
- Partials      913      916       +3     
Flag Coverage Δ
unittests 34.34% <0.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
manager/handlers/audit.go 66.66% <0.00%> (-4.77%) ⬇️

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gaius-qi
Copy link
Member

I think nolint is good for code clearer.

@gaius-qi gaius-qi closed this May 12, 2025
@gaius-qi gaius-qi deleted the refactor(handlers)--wrap-error-handling-in-GetAudits branch May 13, 2025 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants