Skip to content

Conversation

gaius-qi
Copy link
Member

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

… tasks

Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi added this to the v2.3.0 milestone May 14, 2025
@gaius-qi gaius-qi self-assigned this May 14, 2025
@gaius-qi gaius-qi added the enhancement New feature or request label May 14, 2025
@gaius-qi gaius-qi requested review from a team as code owners May 14, 2025 13:18
@gaius-qi gaius-qi requested review from bergwolf, yxxhero and yyzai384 May 14, 2025 13:18
Copy link

@Liam-Zhao Liam-Zhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Liam-Zhao Liam-Zhao enabled auto-merge (squash) May 14, 2025 13:36
Copy link

codecov bot commented May 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.31%. Comparing base (b2664ab) to head (f9bbd73).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4065   +/-   ##
=======================================
  Coverage   34.30%   34.31%           
=======================================
  Files         344      344           
  Lines       40365    40366    +1     
=======================================
+ Hits        13849    13850    +1     
  Misses      25600    25600           
  Partials      916      916           
Flag Coverage Δ
unittests 34.31% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pkg/idgen/task_id.go 82.69% <100.00%> (+0.33%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Liam-Zhao Liam-Zhao merged commit 7a725c7 into main May 14, 2025
30 of 31 checks passed
@Liam-Zhao Liam-Zhao deleted the feature/id branch May 14, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants