feat: update machinery to v1.10.14 and adjust Redis config #4075
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gaius <gaius.qi@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4075 +/- ##
==========================================
- Coverage 34.39% 34.35% -0.04%
==========================================
Files 346 346
Lines 40489 40489
==========================================
- Hits 13925 13911 -14
- Misses 25650 25660 +10
- Partials 914 918 +4
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request includes updates to dependencies and configuration constants to improve performance and compatibility. The most important changes involve upgrading the
dragonflyoss/machinerydependency and adjusting Redis-related configuration defaults.Dependency Updates:
go.mod: Upgradedgithub.com/dragonflyoss/machineryfrom v1.10.13 to v1.10.14 for compatibility and potential bug fixes.Configuration Changes:
internal/job/constants.go: Adjusted Redis configuration defaults:DefaultRedisMaxIdlefrom 0 to 10 and reducedDefaultRedisMaxActivefrom 300 to 50 to optimize connection pooling.DefaultRedisNormalTasksPollPeriodfrom 2000ms to 2500ms for better task polling efficiency.Related Issue
Motivation and Context
Screenshots (if appropriate)
Types of changes
Checklist