Skip to content

Conversation

chlins
Copy link
Member

@chlins chlins commented May 20, 2025

This pull request updates the CONTRIBUTING.md file to improve clarity and ensure consistency regarding Go version requirements and dependency management. The changes replace hardcoded Go version references with instructions to check the go.mod file for the required versions.

Updates to Go version requirements and dependency management:

  • Replaced the hardcoded Go version (v1.15) with a reference to the go.mod file for determining the required version in the tools section. (CONTRIBUTING.md, CONTRIBUTING.mdL242-R242)
  • Updated the dependency management section to instruct contributors to check the go.mod file for required dependency versions, instead of specifying a minimum Go version directly. (CONTRIBUTING.md, CONTRIBUTING.mdL259-R259)

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Signed-off-by: chlins <chlins.zhang@gmail.com>
@chlins chlins requested a review from a team as a code owner May 20, 2025 03:38
@chlins chlins added the documentation Improvements or additions to documentation label May 20, 2025
Copy link

@Liam-Zhao Liam-Zhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chlins
Copy link
Member Author

chlins commented May 23, 2025

Move to dragonflyoss/community#31.

@chlins chlins closed this May 23, 2025
@gaius-qi gaius-qi deleted the docs/contributing.md branch May 29, 2025 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants