Skip to content

Conversation

gaius-qi
Copy link
Member

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi added this to the v2.3.0 milestone May 20, 2025
@gaius-qi gaius-qi self-assigned this May 20, 2025
@gaius-qi gaius-qi requested a review from a team as a code owner May 20, 2025 15:12
@gaius-qi gaius-qi added the enhancement New feature or request label May 20, 2025
Copy link

codecov bot commented May 20, 2025

Codecov Report

Attention: Patch coverage is 40.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 33.18%. Comparing base (93aefb4) to head (47a5975).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
manager/database/database.go 0.00% 2 Missing ⚠️
pkg/redis/redis.go 0.00% 2 Missing ⚠️
scheduler/scheduler.go 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4089      +/-   ##
==========================================
- Coverage   33.18%   33.18%   -0.01%     
==========================================
  Files         346      346              
  Lines       40581    40589       +8     
==========================================
+ Hits        13468    13469       +1     
- Misses      26220    26227       +7     
  Partials      893      893              
Flag Coverage Δ
unittests 33.18% <40.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
scheduler/config/config.go 86.11% <100.00%> (+0.12%) ⬆️
manager/database/database.go 0.00% <0.00%> (ø)
pkg/redis/redis.go 34.92% <0.00%> (-1.15%) ⬇️
scheduler/scheduler.go 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

@Liam-Zhao Liam-Zhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chlins chlins merged commit d31df45 into main May 21, 2025
36 of 37 checks passed
@chlins chlins deleted the feature/pool-size branch May 21, 2025 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants