Skip to content

Conversation

yxxhero
Copy link
Member

@yxxhero yxxhero commented May 21, 2025

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Signed-off-by: yxxhero <aiopsclub@163.com>
@yxxhero yxxhero requested a review from a team as a code owner May 21, 2025 05:55
@yxxhero yxxhero added the documentation Improvements or additions to documentation label May 21, 2025
Copy link

codecov bot commented May 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.18%. Comparing base (d31df45) to head (177888b).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4092      +/-   ##
==========================================
- Coverage   33.19%   33.18%   -0.01%     
==========================================
  Files         346      346              
  Lines       40589    40589              
==========================================
- Hits        13473    13469       -4     
- Misses      26225    26227       +2     
- Partials      891      893       +2     
Flag Coverage Δ
unittests 33.18% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
scheduler/resource/persistentcache/host.go 100.00% <ø> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yxxhero yxxhero enabled auto-merge (squash) May 23, 2025 23:22
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yxxhero yxxhero merged commit 67423da into main May 26, 2025
30 of 35 checks passed
@yxxhero yxxhero deleted the docs(host.go)--Update-NewHost-comment-for-clarity branch May 26, 2025 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants