-
Notifications
You must be signed in to change notification settings - Fork 340
feat: implement PreheatImage and StatImage for scheduler #4246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Gaius <gaius.qi@gmail.com>
b97af46
to
0109347
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4246 +/- ##
==========================================
+ Coverage 32.51% 32.90% +0.39%
==========================================
Files 350 352 +2
Lines 41382 41781 +399
==========================================
+ Hits 13456 13750 +294
- Misses 27035 27139 +104
- Partials 891 892 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
…/preheat Signed-off-by: Gaius <gaius.qi@gmail.com>
fb4fac5
to
99d9a0d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
…/preheat Signed-off-by: Gaius <gaius.qi@gmail.com>
99d9a0d
to
4b41e27
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description
This pull request introduces a series of updates to dependencies, logging utilities, and the preheating functionality for container images. Key changes include dependency updates in
go.mod
, the addition of new logging methods, a refactor of the image preheating logic to use a newManifestRequest
structure, and the removal of an unused configuration parameter. These changes improve maintainability, functionality, and code clarity.Dependency Updates:
go.mod
, includingd7y.io/api/v2
tov2.1.55
,google.golang.org/grpc
tov1.74.2
, andcel.dev/expr
tov0.24.0
. These updates ensure compatibility with the latest versions of external libraries. [1] [2] [3] [4] [5]Logging Enhancements:
WithPreheatImage
,WithStatImage
, andWithStatImageAndTaskID
) ininternal/dflog/logger.go
to enhance flexibility in logging specific operations.Preheating Refactor:
ManifestRequest
structure ininternal/job/image.go
to encapsulate preheating parameters, replacing the previousPreheatArgs
. This refactor simplifies the function signatures and improves readability. [1] [2]CreatePreheatRequestsByManifestURL
function to use the newManifestRequest
structure and updated related logic for building preheat requests. [1] [2] [3]Testing and Mocking:
internal/job/image_test.go
to align with the newManifestRequest
structure. [1] [2] [3]Image
interface ininternal/job/mocks/job_mock.go
to facilitate unit testing.Configuration Cleanup:
RegistryTimeout
parameter from thePreheatConfig
inmanager/config/config.go
, simplifying configuration management. [1] [2] [3]Related Issue
Motivation and Context
Screenshots (if appropriate)
Types of changes
Checklist