Skip to content

Conversation

chlins
Copy link
Member

@chlins chlins commented Aug 18, 2025

This pull request updates the compatibility E2E workflow and the test chart configuration to use newer image versions and adds a new configuration option for the client and seed-client modules. The main changes focus on keeping dependencies up-to-date and improving configuration flexibility.

Dependency updates:

  • Updated the manager and scheduler module images in .github/workflows/compatibility-e2e.yml to use version v2.3.1-rc.4, and updated the client and seed-client images to version v1.0.11.

Configuration enhancements:

  • Added the host.schedulerClusterID field with value 1 to both the seedClient and client sections in test/testdata/charts/config.yaml to support cluster-specific configuration. [1] [2]

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@chlins chlins added the enhancement New feature or request label Aug 18, 2025
Copy link

codecov bot commented Aug 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 32.61%. Comparing base (e169394) to head (c8cb4da).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4273      +/-   ##
==========================================
- Coverage   32.62%   32.61%   -0.01%     
==========================================
  Files         349      349              
  Lines       41368    41368              
==========================================
- Hits        13496    13492       -4     
- Misses      26996    26998       +2     
- Partials      876      878       +2     
Flag Coverage Δ
unittests 32.61% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@chlins chlins force-pushed the chore/v2.3.1-rc.4 branch 6 times, most recently from b6342aa to 2d2f631 Compare August 20, 2025 08:15
Signed-off-by: chlins <chlins.zhang@gmail.com>
@chlins chlins force-pushed the chore/v2.3.1-rc.4 branch from 2d2f631 to c8cb4da Compare August 20, 2025 08:17
@chlins chlins closed this Aug 20, 2025
@chlins chlins deleted the chore/v2.3.1-rc.4 branch August 20, 2025 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants