Rtl fix #209
Rtl fix #209
Conversation
|
@tasnim0tantawi is attempting to deploy a commit to the dottle's projects Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Idk if this absolutely has to be flipped or not but it makes the type pretty difficult to read
Maybe we can force it to be 'ltr' all the time. But then it will be inconsistent with the 'type' of Type fields. Let me know what you think.
Also this breaks the resizing of the side panel so please add this to handleResize
const w = isRtl(i18n.language) ? window.innerWidth - e.clientX : e.clientX;here:
drawdb/src/components/Workspace.jsx
Line 56 in 2f1cca1
Other than that lgtm
| <div | ||
| className="py-1.5 px-5 flex justify-between items-center rounded-xl my-1 sm:mx-1 xl:mx-6 select-none overflow-hidden toolbar-theme" | ||
| style={isRtl(i18n.language) ? { direction: "rtl" } : {}} | ||
| > | ||
| <div className="flex justify-start items-center"> | ||
| <LayoutDropdown /> | ||
| <Divider layout="vertical" margin="8px" /> | ||
| <Dropdown | ||
| style={{ width: "240px" }} | ||
| position="bottomLeft" |
There was a problem hiding this comment.
Could you please add this to position just make the dropdowns all consistent
isRtl(i18n.language) ? "bottomRight" : "bottomLeft"There was a problem hiding this comment.
@1ilit Thanks so much for the code review, I've learned things! Please check my latest commit. I have addressed the issues you mentioned. Also, I made both field name and data type ltr as they will always be in English.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
RTL languages should make the some parts of UI displayed from right to left.
Most the edits I did:
style={isRtl(i18n.language) ? { direction: "rtl" } : {}}Which is changing HTML dir to rtl if the language is one of the known 5 rtl languages.