Skip to content

Commit b87ff93

Browse files
committed
Remove with as it's slightly problematic
1 parent f33486b commit b87ff93

File tree

2 files changed

+2
-55
lines changed

2 files changed

+2
-55
lines changed

config/sets/type-declaration/eloquent.php

Lines changed: 2 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,8 @@
1717
'Illuminate\Database\Eloquent\Model',
1818
'Illuminate\Contracts\Database\Query\Builder',
1919
'Illuminate\Contracts\Database\Eloquent\Builder',
20+
'Illuminate\Database\Eloquent\Builder',
21+
'Illuminate\Database\Query\Builder',
2022
];
2123

2224
$basicPositionOne = [
@@ -29,10 +31,6 @@
2931
'where', 'whereHasMorph', 'orWhereHasMorph', 'whereDoesntHaveMorph', 'orWhereDoesntHaveMorph', 'when',
3032
];
3133

32-
$arrayPositionOne = [
33-
'with', 'withCount',
34-
];
35-
3634
$basicRuleConfiguration = [];
3735
$arrayRuleConfiguration = [];
3836

@@ -64,16 +62,6 @@
6462
$builderClass,
6563
);
6664
}
67-
68-
foreach ($arrayPositionOne as $method) {
69-
$arrayRuleConfiguration[] = new AddParamTypeForFunctionLikeWithinCallLikeArgDeclaration(
70-
$targetClass,
71-
$method,
72-
0,
73-
0,
74-
$builderClass,
75-
);
76-
}
7765
}
7866

7967
$rectorConfig->ruleWithConfiguration(

tests/Sets/TypeDeclaration/Eloquent/Fixture/apply-with-to-model.php.inc

Lines changed: 0 additions & 41 deletions
This file was deleted.

0 commit comments

Comments
 (0)