Skip to content

Add RemoveMigrationDocBlockRector rector #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

glensc
Copy link

@glensc glensc commented Jun 5, 2025

Cleans up useless phpdoc:

-/**
- * Run the migrations.
- *
- * @return void
- */
public function up()
{
    // ...
}

-/**
- * Reverse the migrations
- *
- * @return void
- */
public function down()
{
    // ...
}

@glensc
Copy link
Author

glensc commented Jun 5, 2025

Please assist on:

  1. will this be accepted?
  2. how to name this?
  3. what namespace to put the class?

Self-review:

  1. the @return void can be done with other rules, so should be removed from this rector regex?

@peterfox
Copy link
Collaborator

I'll be honest I don't see this being an efficient use of a rector rule that we'd want to maintain. Happy to give some guidance in how you might write such a rule if you'd still want help with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants