Use whereKey query method where possible#401
Open
imliam wants to merge 2 commits intodriftingly:mainfrom
Open
Conversation
Contributor
imliam
commented
Oct 4, 2025
imliam
commented
calebdw
requested changes
Dec 23, 2025
Comment on lines
+84
to
+90
| if ($argCount === 2) { | ||
| return $this->refactorTwoArgumentWhere($node, $args, $isWhereNot); | ||
| } | ||
|
|
||
| if ($argCount === 3 && $isWhere) { | ||
| return $this->refactorThreeArgumentWhere($node, $args); | ||
| } |
Collaborator
There was a problem hiding this comment.
can these be condensed into a single method? they look quite similar
| } | ||
|
|
||
| $propertyFetch = $args[1]->value; | ||
| if (! $this->isName($propertyFetch->name, 'id')) { |
Collaborator
There was a problem hiding this comment.
instead of hardcoding id here, it would be better to get a new model instance from the helpers, and then use the result of ->getKeyName()
There was a problem hiding this comment.
That's an essential point. Not every system has the 'id' as the primary key.
Collaborator
|
I'm not sure if there's another rule that does this, but I'd also like a rule (or just update this rule) that turns |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.