Fix bug in readme code sample #26
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
I was trying out this mongoose plugin some days ago and I figured one of the code samples in the README is not working as expected. This PR attempts to fixe the issue.
The Issue:
There is this code sample in the README:
When I run this locally, it prints:
A click from "127.0.0.1" using "undefined" was found. I figured the first query inserts two different documents({ip: '127.0.0.1'}and{browser: 'Mozilla'}) in the DB, while the second query does nothing since the document matching{ip: '127.0.0.1'}already exists.The fix:
I updated the code sample to use
Click.findOrCreatefor the first query:When I run this, it prints the expected message:
A click from "127.0.0.1" using "Mozilla" was found. The first query inserts just a single document (merging the first and second argument), while the second query still does nothing since the document matching{ip: '127.0.0.1'}already exists.