refactor!: remove launch_template variable

radimsuckr · radimsuckr · commit 763c8f7b8699 · 2022-11-30T11:01:10.000+01:00
diff --git a/iam.tf b/iam.tf
@@ -49,9 +49,7 @@ data "aws_iam_policy_document" "lambda" {
       "ec2:ModifyLaunchTemplate",
     ]
 
-    resources = [
-      data.aws_launch_template.template.arn,
-    ]
+    resources = var.launch_templates_arns
   }
 
   statement {
diff --git a/main.tf b/main.tf
@@ -5,7 +5,3 @@ data "aws_region" "current" {}
 data "aws_autoscaling_group" "group" {
   name = var.autoscaling_group_name
 }
-
-data "aws_launch_template" "template" {
-  name = var.launch_template_name
-}
diff --git a/outputs.tf b/outputs.tf
@@ -1,15 +1,3 @@
 output "asg_arn" {
   value = data.aws_autoscaling_group.group.arn
 }
-
-output "lt_arn" {
-  value = data.aws_launch_template.template.arn
-}
-
-output "lt_id" {
-  value = data.aws_launch_template.template.id
-}
-
-output "lt_name" {
-  value = data.aws_launch_template.template.name
-}
diff --git a/variables.tf b/variables.tf
@@ -99,9 +99,10 @@ variable "lambda_timeout" {
   type        = number
 }
 
-variable "launch_template_name" {
-  description = "Name of the launch template used by auto scaling group to refresh"
-  type        = string
+variable "launch_templates_arns" {
+  description = "List of Launch Template ARNs to allow access to"
+  default     = ["*"]
+  type        = list(string)
 }
 
 variable "launch_template_source_version" {

Original file line number	Diff line number	Diff line change
`@@ -49,9 +49,7 @@ data "aws_iam_policy_document" "lambda" {`
`49`	`49`	`"ec2:ModifyLaunchTemplate",`
`50`	`50`	`]`
`51`	`51`
`52`		`- resources = [`
`53`		`- data.aws_launch_template.template.arn,`
`54`		`- ]`
	`52`	`+ resources = var.launch_templates_arns`
`55`	`53`	`}`
`56`	`54`
`57`	`55`	`statement {`
Original file line number	Diff line number	Diff line change
`@@ -5,7 +5,3 @@ data "aws_region" "current" {}`
`5`	`5`	`data "aws_autoscaling_group" "group" {`
`6`	`6`	`name = var.autoscaling_group_name`
`7`	`7`	`}`
`8`		`-`
`9`		`-data "aws_launch_template" "template" {`
`10`		`- name = var.launch_template_name`
`11`		`-}`
Original file line number	Diff line number	Diff line change
`@@ -99,9 +99,10 @@ variable "lambda_timeout" {`
`99`	`99`	`type = number`
`100`	`100`	`}`
`101`	`101`
`102`		`-variable "launch_template_name" {`
`103`		`- description = "Name of the launch template used by auto scaling group to refresh"`
`104`		`- type = string`
	`102`	`+variable "launch_templates_arns" {`
	`103`	`+ description = "List of Launch Template ARNs to allow access to"`
	`104`	`+ default = ["*"]`
	`105`	`+ type = list(string)`
`105`	`106`	`}`
`106`	`107`
`107`	`108`	`variable "launch_template_source_version" {`