-
Notifications
You must be signed in to change notification settings - Fork 34
Open
Labels
enhancementThe issue is an enhancement request.The issue is an enhancement request.help wantedThe issue is up for grabs for anyone in the community.The issue is up for grabs for anyone in the community.
Description
Description
The current implementation includes a custom New-TerminatingError function in the DhcpServerDsc.Common module. This should be replaced with the standardized error helper functions available in DscResource.Common.
Background
As per DSC Community guidelines, we should check DscResource.Common before creating private functions. The DscResource.Common module provides several error helper functions such as:
- New-InvalidDataException
- New-ArgumentException
- New-InvalidOperationException
- New-ObjectNotFoundException
- New-InvalidResultException
- New-NotImplementedException
Tasks
- Review usage of New-TerminatingError in DhcpServerDsc.Common
- Replace with appropriate DscResource.Common error functions
- Update unit tests accordingly
- Remove the custom New-TerminatingError function
References
- PR: Convert nested modules to buildable modules #96
- Comment: Convert nested modules to buildable modules #96 (comment)
Requested by: @dan-hughes
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
enhancementThe issue is an enhancement request.The issue is an enhancement request.help wantedThe issue is up for grabs for anyone in the community.The issue is up for grabs for anyone in the community.